Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mon: calculate min_size on osd pool set size #34342

Merged
merged 2 commits into from
Apr 8, 2020
Merged

mon: calculate min_size on osd pool set size #34342

merged 2 commits into from
Apr 8, 2020

Conversation

ideepika
Copy link
Member

@ideepika ideepika commented Apr 1, 2020 •
edited
Loading

currently osd pool set size only modifies min_size when it is above new size,
while it should be recalculated unconditionally.

fixes: https://tracker.ceph.com/issues/44862
Signed-off-by: Deepika Upadhyay dupadhya@redhat.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard backend
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@ideepika ideepika added the mon label Apr 1, 2020
jdurgin
jdurgin reviewed Apr 1, 2020
View reviewed changes
Copy link
Member

@jdurgin jdurgin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add checking min_size to this test?

qa/workunits/mon/pool_ops.sh

Deepika Upadhyay added 2 commits April 2, 2020 12:30
mon: calculate min_size on osd pool set size
b69dcaa 
currently `osd pool set size` only modifies min_size when it is above new size,
while it should be recalculated unconditionally.

fixes: https://tracker.ceph.com/issues/44862
Signed-off-by: Deepika Upadhyay <dupadhya@redhat.com>
qa/workunits/mon: add check for min_size
0a7325a 
verify whether min_size is recalculated when osd
pool size is changed.

fixes: https://tracker.ceph.com/issues/44862
Signed-off-by: Deepika Upadhyay <dupadhya@redhat.com>
@ideepika
Copy link
Member Author

ideepika commented Apr 2, 2020

could you add checking min_size to this test?

qa/workunits/mon/pool_ops.sh

ack.
test runs for qa/workunits/mon/pool_ops.sh:
http://pulpito.front.sepia.ceph.com/ideepika-2020-04-02_09:47:12-rados:singleton-bluestore:all-wip-deepika-testing-fix-44862-distro-basic-smithi/
http://pulpito.front.sepia.ceph.com/ideepika-2020-04-02_12:43:22-rados:monthrash:workloads-wip-deepika-testing-fix-44862-distro-basic-smithi/

jdurgin
jdurgin approved these changes Apr 2, 2020
View reviewed changes
Copy link
Member

@jdurgin jdurgin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

@tchaikov
Copy link
Contributor

tchaikov commented Apr 8, 2020

@tchaikov tchaikov merged commit ae9247b into ceph:master Apr 8, 2020
This was referenced Apr 12, 2020
Merged
Merged
Closed
@ideepika ideepika deleted the fixes-44862 branch April 29, 2021 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdurgin jdurgin jdurgin approved these changes

@neha-ojha neha-ojha neha-ojha approved these changes

Assignees
No one assigned
Labels
mon needs-qa wip-kefu-testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ideepika @tchaikov @jdurgin @neha-ojha