radosgw-admin: skip GC init on read-only admin ops #41027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins test make check |
mattbenjamin
approved these changes
Apr 26, 2021
src/rgw/rgw_rados.h
Outdated
| @@ -480,6 +480,7 @@ class RGWRados | |||
| RGWIndexCompletionManager *index_completion_manager{nullptr}; | |||
|
|
|||
| bool use_cache{false}; | |||
| bool readonly{false}; | |||
There was a problem hiding this comment.
I guess this makes sense. I am more strongly preferring the idea of pulling admin into a remote service all the time.
dang
approved these changes
Apr 26, 2021
mkogan1
force-pushed
the
wip-rgw-gc-max-objsf2
branch
from
1bc086c
to
d3fb7d8
Compare
|
jenkins test make check |
mkogan1
force-pushed
the
wip-rgw-gc-max-objsf2
branch
2 times, most recently
from
e1e85e8
to
fecb9cc
Compare
|
updated as discussed on stadup, |
mattbenjamin
approved these changes
Apr 27, 2021
mkogan1
force-pushed
the
wip-rgw-gc-max-objsf2
branch
from
fecb9cc
to
91b8521
Compare
Fixes: https://tracker.ceph.com/issues/50520 Signed-off-by: Mark Kogan <mkogan@redhat.com>
mkogan1
force-pushed
the
wip-rgw-gc-max-objsf2
branch
from
91b8521
to
9ac1991
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://tracker.ceph.com/issues/50520
Signed-off-by: Mark Kogan mkogan@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox