octopus: radosgw-admin: skip GC init on read-only admin ops #45423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbodley
reviewed
May 6, 2022
src/rgw/rgw_rados.cc
Outdated
| gc = new RGWGC(); | ||
| gc->initialize(cct, this); | ||
| } else { | ||
| ldpp_dout(dpp, 5) << "note: GC not initialized" << dendl; |
There was a problem hiding this comment.
/ceph-15.2.16-105-g682160e1/src/rgw/rgw_rados.cc:22:
/ceph-15.2.16-105-g682160e1/src/rgw/rgw_rados.cc: In member function ‘int RGWRados::init_complete()’:
/ceph-15.2.16-105-g682160e1/src/rgw/rgw_rados.cc:1191:15: error: ‘dpp’ was not declared in this scope
ldpp_dout(dpp, 5) << "note: GC not initialized" << dendl;
^~~
Fixes: https://tracker.ceph.com/issues/50520 Signed-off-by: Mark Kogan <mkogan@redhat.com> (cherry picked from commit 9ac1991) Conflicts: src/rgw/rgw_admin.cc src/rgw/rgw_rados.h src/rgw/rgw_sal.cc src/rgw/rgw_sal.h Cherry-pick notes: - src/rgw/rgw_admin.cc: conflicts due to differences in op lists - src/rgw/rgw_rados.h: conflicts due to changes to unrelated method signatures - src/rgw/rgw_sal.cc: conflicts due to octopus missing a couple of methods from later releases - src/rgw/rgw_sal.h: conflicts due to changes to unrelated method seignatures - src/rgw/rgw_rados.cc: use of ldpp_dout vs. ldout
cfsnyder
force-pushed
the
wip-50802-octopus
branch
from
b36e6e8
to
6bc9588
Compare
cbodley
approved these changes
May 19, 2022
|
jenkins test api |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/50802
backport of #41027
parent tracker: https://tracker.ceph.com/issues/50520
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh