Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

octopus: mon/MonCommands.h: fix target_size_ratio range #45398

Merged
merged 3 commits into from
May 11, 2022
Merged

octopus: mon/MonCommands.h: fix target_size_ratio range #45398

merged 3 commits into from
May 11, 2022

Conversation

kamoltat
Copy link
Member

@kamoltat kamoltat commented Mar 15, 2022 •
edited
Loading

  • Modified the range of target_size_ratio from 0.0 -> 1.0 to 0.0 -> nolimit
  • Throw an error when user set target_size_ratio to negative using the command:
    osd pool set <pool> target_size_ratio <float>
  • Added test cases regardingtarget_size_ratio to qa/workunits/cephtool/test.sh
  • Did not cherry-pick 4add5feff657aad2afbec56a21b544bedf7f9b95 because octopus doesn't contain the commit that contains white space.

Backporting related commits from master PR(s):
#45078

Fixes: https://tracker.ceph.com/issues/54568

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@kamoltat
mon/MonCommands.h: fix target_size_ratio range
8aa2d17 
The `target_size_ratio` should be 0.0 -> nolimit
not limited to 0.0 -> 1.0

Fixes: https://tracker.ceph.com/issues/54316

Signed-off-by: Kamoltat <ksirivad@redhat.com>
(cherry picked from commit e5a5b81)

Conflicts:
	src/mon/MonCommands.h
		- trivial fix
@kamoltat
mon/OSDMonitor.cc: cannot set target_size_ratio to negative
2f1d96d 
Throw an error when user set `target_size_ratio`
to negative using the command:

`osd pool set <pool> target_size_ratio <float>`

Signed-off-by: Kamoltat <ksirivad@redhat.com>
(cherry picked from commit 1b88205)
@kamoltat
qa/workunits/cephtool/test.sh: added test cases for target_size_ratio
752e219 
Test the commands:

`osd pool create` <pool> --target_size_ratio <float>

`osd pool set` <pool> target_size_ratio <float>

`osd pool get` <pool> target_size_ratio

Signed-off-by: Kamoltat <ksirivad@redhat.com>
(cherry picked from commit 0978547)
@github-actions github-actions bot added this to the octopus milestone Mar 15, 2022
@kamoltat kamoltat requested a review from neha-ojha March 15, 2022 18:26
@kamoltat kamoltat self-assigned this Mar 15, 2022
@neha-ojha
Copy link
Member

jenkins test make check

1 similar comment
@kamoltat
Copy link
Member Author

jenkins test make check

@kamoltat
Copy link
Member Author

kamoltat commented Mar 24, 2022 •
edited
Loading

make check dashboard failure seems unrelated and found the tracker https://tracker.ceph.com/issues/55011#change-213145:

    Attempted to log "Error: Uncaught [TypeError: Cannot read property 'documentElement' of null]
        at reportException (/home/jenkins-build/build/workspace/ceph-pull-requests/src/pybind/mgr/dashboard/frontend/node_modules/jsdom/lib/jsdom/living/helpers/runtime-script-errors.js:62:24)
        at notifyMutationObservers (/home/jenkins-build/build/workspace/ceph-pull-requests/src/pybind/mgr/dashboard/frontend/node_modules/jsdom/lib/jsdom/living/helpers/mutation-observers.js:166:11)
        at Promise.resolve.then (/home/jenkins-build/build/workspace/ceph-pull-requests/src/pybind/mgr/dashboard/frontend/node_modules/jsdom/lib/jsdom/living/helpers/mutation-observers.js:133:5)
        at process._tickCallback (internal/process/next_tick.js:68:7) TypeError: Cannot read property 'documentElement' of null
        at documentElement (/home/jenkins-build/build/workspace/ceph-pull-requests/src/pybind/mgr/dashboard/frontend/node_modules/simplebar/dist/simplebar.min.js:10:58709)
        at Proxy.forEach (<anonymous>)
        at call (/home/jenkins-build/build/workspace/ceph-pull-requests/src/pybind/mgr/dashboard/frontend/node_modules/simplebar/dist/simplebar.min.js:10:58614)
        at Proxy.forEach (<anonymous>)
        at call (/home/jenkins-build/build/workspace/ceph-pull-requests/src/pybind/mgr/dashboard/frontend/node_modules/simplebar/dist/simplebar.min.js:10:58408)
        at Array.forEach (<anonymous>)
        at MutationObserverImpl.forEach (/home/jenkins-build/build/workspace/ceph-pull-requests/src/pybind/mgr/dashboard/frontend/node_modules/simplebar/dist/simplebar.min.js:10:57953)
        at ZoneDelegate.Object.<anonymous>.ZoneDelegate.invoke (/home/jenkins-build/build/workspace/ceph-pull-requests/src/pybind/mgr/dashboard/frontend/node_modules/zone.js/dist/zone.js:391:26)
        at Zone.Object.<anonymous>.Zone.runGuarded (/home/jenkins-build/build/workspace/ceph-pull-requests/src/pybind/mgr/dashboard/frontend/node_modules/zone.js/dist/zone.js:161:47)
        at MutationObserverImpl._callback (/home/jenkins-build/build/workspace/ceph-pull-requests/src/pybind/mgr/dashboard/frontend/node_modules/zone.js/dist/zone.js:144:29)
        at notifyMutationObservers (/home/jenkins-build/build/workspace/ceph-pull-requests/src/pybind/mgr/dashboard/frontend/node_modules/jsdom/lib/jsdom/living/helpers/mutation-observers.js:158:14)
        at Promise.resolve.then (/home/jenkins-build/build/workspace/ceph-pull-requests/src/pybind/mgr/dashboard/frontend/node_modules/jsdom/lib/jsdom/living/helpers/mutation-observers.js:133:5)
        at process._tickCallback (internal/process/next_tick.js:68:7)".```

@kamoltat
Copy link
Member Author

@neha-ojha think this one should be good for testing

@ljflores
Copy link
Contributor

http://pulpito.front.sepia.ceph.com/yuriw-2022-04-26_20:58:55-rados-wip-yuri2-testing-2022-04-26-1132-octopus-distro-default-smithi/
http://pulpito.front.sepia.ceph.com/yuriw-2022-05-09_21:42:51-rados-wip-yuri2-testing-2022-04-26-1132-octopus-distro-default-smithi/

Failures, unrelated:
https://tracker.ceph.com/issues/55347
https://tracker.ceph.com/issues/45327
https://tracker.ceph.com/issues/55531
https://tracker.ceph.com/issues/52993
https://tracker.ceph.com/issues/43584

Details:
1. SELinux Denials during cephadm/workunits/test_cephadm - Ceph - Orchestrator
2. cephadm: Orch daemon add is not idempotent - Ceph - Orchestrator
3. octopus: No remote osd logs captured in dead jobs - Ceph
4. upgrade:octopus-x Test: Upgrade test failed due to timeout of the "ceph pg dump" command - Ceph - RADOS
5. MON_DOWN during mon_join process - Ceph - RADOS (pending Octopus backport)

@yuriw
Copy link
Contributor

yuriw commented May 11, 2022

jenkins test make check

@yuriw
Copy link
Contributor

yuriw commented May 11, 2022

jenkins test make check

1 similar comment
@ljflores
Copy link
Contributor

jenkins test make check

@yuriw yuriw merged commit 2841f0a into ceph:octopus May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neha-ojha neha-ojha neha-ojha approved these changes

Assignees

@kamoltat kamoltat

Labels
core needs-qa needs-test ready-to-merge wip-yuri2-testing
Projects
None yet
Milestone
octopus
Development

Successfully merging this pull request may close these issues.
4 participants
@kamoltat @neha-ojha @ljflores @yuriw