Skip to content

mon/MonCommands.h: fix target_size_ratio range#45078

Merged
yuriw merged 4 commits intoceph:masterfrom
kamoltat:wip-ksirivad-fix-target-size-ratio-bound
Mar 15, 2022
Merged

mon/MonCommands.h: fix target_size_ratio range#45078
yuriw merged 4 commits intoceph:masterfrom
kamoltat:wip-ksirivad-fix-target-size-ratio-bound

Conversation

@kamoltat
Copy link
Copy Markdown
Member

@kamoltat kamoltat commented Feb 17, 2022 •
edited
Loading

  • Modified the range of target_size_ratio from 0.0 -> 1.0 to 0.0 -> nolimit
  • Throw an error when user set target_size_ratio to negative using the command:
    osd pool set <pool> target_size_ratio <float>
  • Added test cases regardingtarget_size_ratio to qa/workunits/cephtool/test.sh
  • Removed white space and weird indentations in qa/workunits/mon/pg_autoscaler.sh

Fixes: https://tracker.ceph.com/issues/54316

Signed-off-by: Kamoltat ksirivad@redhat.com

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@kamoltat kamoltat requested a review from neha-ojha February 17, 2022 17:43
@kamoltat kamoltat self-assigned this Feb 17, 2022
@kamoltat kamoltat force-pushed the wip-ksirivad-fix-target-size-ratio-bound branch from 3faa7d2 to 767f14d Compare February 17, 2022 17:48
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 23, 2022

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@neha-ojha
Copy link
Copy Markdown
Member

neha-ojha commented Mar 1, 2022

@kamoltat could you please rebase this PR?

@kamoltat kamoltat force-pushed the wip-ksirivad-fix-target-size-ratio-bound branch from 767f14d to 52da219 Compare March 1, 2022 21:17
@kamoltat
Copy link
Copy Markdown
Member Author

kamoltat commented Mar 3, 2022

jenkins retest this please

@kamoltat
mon/MonCommands.h: fix target_size_ratio range
e5a5b81 
The `target_size_ratio` should be 0.0 -> nolimit
not limited to 0.0 -> 1.0

Fixes: https://tracker.ceph.com/issues/54316

Signed-off-by: Kamoltat <ksirivad@redhat.com>
@kamoltat kamoltat force-pushed the wip-ksirivad-fix-target-size-ratio-bound branch from 52da219 to e5a5b81 Compare March 3, 2022 20:48
kamoltat added 3 commits March 4, 2022 16:18
@kamoltat
mon/OSDMonitor.cc: cannot set target_size_ratio to negative
1b88205 
Throw an error when user set `target_size_ratio`
to negative using the command:

`osd pool set <pool> target_size_ratio <float>`

Signed-off-by: Kamoltat <ksirivad@redhat.com>
@kamoltat
qa/workunits/cephtool/test.sh: added test cases for target_size_ratio
0978547 
Test the commands:

`osd pool create` <pool> --target_size_ratio <float>

`osd pool set` <pool> target_size_ratio <float>

`osd pool get` <pool> target_size_ratio

Signed-off-by: Kamoltat <ksirivad@redhat.com>
@kamoltat
qa/workunits/mon/pg_autoscaler.sh: clean up white space
4add5fe 
remove white space and weird indentations

Signed-off-by: Kamoltat <ksirivad@redhat.com>
@github-actions github-actions bot added the tests label Mar 4, 2022
@kamoltat
Copy link
Copy Markdown
Member Author

kamoltat commented Mar 4, 2022

jenkins test make check

@kamoltat
Copy link
Copy Markdown
Member Author

kamoltat commented Mar 4, 2022

jenkins test windows

@kamoltat
Copy link
Copy Markdown
Member Author

kamoltat commented Mar 4, 2022

1/1 passed for testing cephtool/test.sh

Verified that in teuthology.log, all added test cases has been exercised

ksirivad-2022-03-04_18:43:53-rados:singleton-bluestore:all:cephtool.yaml-wip-ksirivad-fix-target-size-ratio-bound-distro-basic-smithi/6720605/

@ljflores
Copy link
Copy Markdown
Member

ljflores commented Mar 5, 2022

jenkins test make check

@kamoltat
Copy link
Copy Markdown
Member Author

kamoltat commented Mar 7, 2022

jenkins test windows

@kamoltat
Copy link
Copy Markdown
Member Author

kamoltat commented Mar 10, 2022

jenkins test windows

@kamoltat kamoltat removed the needs-qa label Mar 10, 2022
@yuriw yuriw merged commit 7bd2450 into ceph:master Mar 15, 2022
@kamoltat
Copy link
Copy Markdown
Member Author

kamoltat commented Mar 15, 2022

4/4 passed in
https://pulpito.ceph.com/ksirivad-2022-03-15_15:45:00-rados:singleton-bluestore-wip-ksirivad-fix-target-size-ratio-bound-distro-basic-smithi/

@kamoltat kamoltat added needs-quincy-backport backport required for quincy needs-pacific-backport PR needs a pacific backport labels Mar 15, 2022
This was referenced Mar 15, 2022
Merged
Merged
@kamoltat kamoltat added the needs-octopus-backport PR needs a octoupus bacport label Mar 15, 2022
@kamoltat kamoltat mentioned this pull request Mar 15, 2022
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@neha-ojha neha-ojha neha-ojha approved these changes

Assignees

@kamoltat kamoltat

Labels

core mon needs-octopus-backport PR needs a octoupus bacport needs-pacific-backport PR needs a pacific backport needs-quincy-backport backport required for quincy tests wip-yuri-testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kamoltat @neha-ojha @ljflores @yuriw