-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmake: enforce gcc-10 for win32 port #47594
Conversation
we only have GCC-10 targeting MinGW at the time of writing, and it is good enough for compiling the Winows port. so let's relax the requirement to enable the windows build. Signed-off-by: Kefu Chai <tchaikov@gmail.com>
jenkins test make check |
jenkins test api |
|
jenkins test make check |
2 similar comments
jenkins test make check |
jenkins test make check |
Thanks, this buys us some time. I see that one of the tests keeps failing, we'll take a look:
|
Yet
|
the cmake output show that it selected 9.3
|
it's using these binaries:
|
Ah, you're right. ceph/ceph-build#2067 (This also tells me we didn't need to update the Jenkins builders to Jammy 😞) |
why? i did spot FTBFS of windows build on ubuntu focal. |
I don't know. I thought I remember @petrutlucian94 or @ionutbalutoiu asking me to switch Windows builds to Jammy builders specifically because of a newer something version. ceph/ceph-build#2067 does get builds going again but it's failing now due to a compiler error.
|
@djgalloway right, the issue was that ubuntu 20.04 only provides mingw gcc 9.3
Now we have some failing tests that are addressed by this PR: #47818. The windows job completed successfully there. |
we only have GCC-10 targeting MinGW at the time of writing, and it
is good enough for compiling the Winows port.
so let's relax the requirement to enable the windows build.
Signed-off-by: Kefu Chai tchaikov@gmail.com
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test dashboard cephadm
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox
jenkins test windows