pacific: mgr/dashboard: fix nfs exports form issues with squash field #47960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Squash is not a mandatory field. 2. If the export is created from backend, then squash can have many different names for each types of squash. for eg. ``` ['root', 'root_squash', 'rootsquash', 'rootid', 'root_id_squash', 'rootidsquash', 'all', 'all_squash', 'allsquash', 'all_anomnymous', 'allanonymous', 'no_root_squash', 'none', 'noidsquash'] ``` so we need a proper matching in the ui too otherwise the edit field will not have any value for the squash field. 3. Removed unncessary dropdown helper if there are values for the squash and access types. Fixes: https://tracker.ceph.com/issues/57114 Signed-off-by: Nizamudeen A <nia@redhat.com> (cherry picked from commit 23c00ed)
This actually broke the doc service when the developer environment is of main branch Signed-off-by: Nizamudeen A <nia@redhat.com> (cherry picked from commit be5ab2f)
nizamial09
requested review from
avanthakkar and
pereman2
and removed request for
a team
avanthakkar
approved these changes
Sep 20, 2022
pereman2
approved these changes
Oct 4, 2022
|
jenkins test make check |
|
jenkins test api |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/57435
backport of #47571
parent tracker: https://tracker.ceph.com/issues/57114
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh