Various fixes #79
Merged
Various fixes #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't have a lengthy version for the description of the App. Signed-off-by: Sébastien Han <seb@redhat.com>
We must show logs that are 30 seconds old. 30 sec represents the average time for the container to bootstrap. If you restart the container, the logs are not flushed, so if we don't limit the amount of logs to grep we will obviously grep the initial SUCCESS occurence (representing the initial invocation/bootstrap of cn). A restart might not succeed and the only way to have grepForSuccess working correctly is to grep through the latest logs. Signed-off-by: Sébastien Han <seb@redhat.com>
The timeout is 60 sec not 30sec. Signed-off-by: Sébastien Han <seb@redhat.com>
We now show stderr logs so we can actually see what's wrong. Signed-off-by: Sébastien Han <seb@redhat.com>
This was referenced Oct 22, 2018
leseb
force-pushed
the
various-fixes
branch
3 times, most recently
from
7db5930
to
54e6167
Compare
It's not necessary to wait longer than that. Also curlTestURL does not behave correctly after 16 attemps, the http.Get(url) call is slow to return anything, it basically hangs, which increases the whole timeout. Signed-off-by: Sébastien Han <seb@redhat.com>
This is helpful for the user. Signed-off-by: Sébastien Han <seb@redhat.com>
During the initial bootstrap, the cluster might start but rgw can fail for whatever reasons. This means there are no logs to show from the container, now if the output returns "No such file or directory" we simply don't print anything. This is better than printing the "No such file or directory" error. Signed-off-by: Sébastien Han <seb@redhat.com>
This commit splits the image_list into 2 new functions, one for rhcs when enabled and the default Docker. Signed-off-by: Sébastien Han <seb@redhat.com>
We know the cluster name already since it's passed in the CLI so let's simply re-use it. Signed-off-by: Sébastien Han <seb@redhat.com>
Explain that we can pass a registry also when starting a specific image. Signed-off-by: Sébastien Han <seb@redhat.com>
Soon cn will support the downstream version so let's hide the upstream name and compute it at build time (coming in the next commit) Signed-off-by: Sébastien Han <seb@redhat.com>
Update the link with the latest tag and add the link to the arm64 build too. Signed-off-by: Sébastien Han <seb@redhat.com>
Prior to this commit, the output of each s3 command will give the internal cluster name (user's given name + prefix: ceph-nano) wheere users need to see the name they gave. Fixes: #63 Signed-off-by: Sébastien Han <seb@redhat.com>
Now you can run any s3 command with '--debug' or '-d' and it will output the s3cmd logs when connecting to s3. Fixes: #60 Signed-off-by: Sébastien Han <seb@redhat.com>
This helps Travis CI not failing because of rate limit error, typically the container will ask for the latest tag, but since Travis pulls the image multiple time (during functional tests) then Github will complain and return an empty URL. Signed-off-by: Sébastien Han <seb@redhat.com>
ErwanAliasr1
approved these changes
Oct 23, 2018
cmd/utils.go
Outdated
| @@ -280,7 +280,7 @@ func parseArray(anArray []interface{}, keyType string) { | |||
| // CephNanoS3Health loops for 30 seconds while testing Ceph RGW health | |||
There was a problem hiding this comment.
Comment should be changed accordingly
| @@ -28,5 +29,8 @@ func showS3Logs(containerName string) { | |||
| notExistCheck(containerName) | |||
| c := []string{"cat", "/var/log/ceph/client.rgw." + containerName + "-faa32aebf00b.log"} | |||
| output := execContainer(containerName, c) | |||
| if strings.Contains("No such file or directory", output) { | |||
There was a problem hiding this comment.
Are you sure about the Locale of that message ?
cmd/purge.go
Outdated
| @@ -40,7 +40,7 @@ func cliClusterPurge() *cobra.Command { | |||
| // purgeNano purges Ceph Nano. | |||
| func purgeNano(cmd *cobra.Command, args []string) { | |||
| containerName := containerNamePrefix + args[0] | |||
There was a problem hiding this comment.
as you use args[0] twice, would worth having a variable to name what it is like.
This was referenced Oct 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.