src: Add hot reload option for development #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pulpito ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@VallariAg Sorry I closed the other one by accident, staging, and forgot to create a commit before force pushing lol Anyways, I got rid of the package-lock changes. |
VallariAg
reviewed
Feb 5, 2024
| @@ -20,6 +20,10 @@ export default defineConfig(() => { | |||
| ], | |||
| server: { | |||
| port: 8081, | |||
| host: true, | |||
| watch: { | |||
| usePolling: true, | |||
There was a problem hiding this comment.
Everything looks good! Just one small thing: according to the docs, usePolling uses high CPU utilisation so we should probably be using this for developer setup only and not production env? https://vitejs.dev/config/server-options#server-watch
Allow hot reload in Development mode for pulpito-ng. This saves a lot more time when developing with other tech stacks. Signed-off-by: Kamoltat Sirivadhna <ksirivad@redhat.com>
kamoltat
force-pushed
the
wip-ksirivad-add-start-container
branch
from
c5b3262
to
a6f8888
Compare
|
@VallariAg updated the vite.config.js just need approval for merge |
VallariAg
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow hot reload in Development mode for
pulpito-ng. This saves a lot more time
when developing with other tech stacks.