Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(DNM) Run Page: Testing performance improvements #75

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

VallariAg
Copy link
Member

@VallariAg VallariAg commented Jun 14, 2024

Using React Profiler to see which component is slow....

Local paddles with no runs:
image

This commit has render time of 205ms.

Ideas to improve:

  1. Do not process jobs when loading RunList.
    This might improve the load time of run page.
    Only need to process jobs for 'useRun' query for JobList.
  2. Do not load RunList filters by default so we can avoid loading DateField and DesktopDatePicker

Also, (production) paddles network request takes +900ms:
image

Do not process jobs when loading RunList.
This might improve the load time of run page.

Only need to process jobs for 'useRun' query
for JobList.

Signed-off-by: Vallari Agrawal <val.agl002@gmail.com>
Copy link

render bot commented Jun 14, 2024

Copy link

netlify bot commented Jun 14, 2024

Deploy Preview for pulpito ready!

Name Link
🔨 Latest commit 9c7543b
🔍 Latest deploy log https://app.netlify.com/sites/pulpito/deploys/666bed8eabee1c00080b42aa
😎 Deploy Preview https://deploy-preview-75--pulpito.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Vallari Agrawal <val.agl002@gmail.com>
@VallariAg VallariAg changed the title paddles.d.ts: Add 'RunWithJobs' interface Run Page: Improving performance Jun 14, 2024
@kamoltat kamoltat self-requested a review June 24, 2024 14:22
@kamoltat kamoltat added the enhancement Making existing feature better label Jun 24, 2024
Copy link
Member

@kamoltat kamoltat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for making this faster.

@VallariAg VallariAg changed the title Run Page: Improving performance Run Page: Testing performance improvements Aug 13, 2024
@VallariAg VallariAg changed the title Run Page: Testing performance improvements (DNM) Run Page: Testing performance improvements Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Making existing feature better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants