platform.linux_distribution() is deprecated; stop using it

[smithfarm]

Fixes: http://tracker.ceph.com/issues/18141
Signed-off-by: Nathan Cutler ncutler@suse.com

[smithfarm]

@zmc Ping

[zmc]

Where is platform.linux_distribution() deprecated?

This would need to be tested with all OSes to ensure we wouldn't regress.

[smithfarm]

platform.linux_distribution() is deprecated since python 3.5, and will be removed in python 3.7 (see https://docs.python.org/3.6/library/platform.html#platform.linux_distribution).

[smithfarm]

The implementation in Python 2.7 returns (,,) on newer distros like openSUSE Tumbleweed (which dropped the old /etc/SuSE-release now that /etc/os-release is the new standard). I think this (,,) return value happens in newer Fedoras as well, but I haven't tried it.

[smithfarm]

@zmc When you say "all OSes" which OSes do you mean? Are there any that don't have /etc/os-release ?

[ktdreyer]

FYI mock recently switched to the distro lib, now that platform.dist and platform.linux_distribution are going away in py37.

[smithfarm]

@ktdreyer Do we need an elaborate python module when a glance at /etc/os-release gives us the information we need?

[ktdreyer]

Teuthology does a lot already - it was just a suggestion :)

[smithfarm]

In ceph/ceph#23111 I have unit tests that cover "all" OSes. I will add a commit to this PR implementing these unit tests in teuthology so we can be confident that platform.linux_distribution is no longer needed.

[smithfarm]

Added unit tests and support for new distros. Pinging again for review.

[gregsfortytwo]

This looks good to me. @zmc, is there other testing we can do besides rolling it out in the lab? If not I think we should just go for it...

[smithfarm]

I will run some ad-hoc tests.

[smithfarm]

@zmc Ping

[gregsfortytwo]

Well, I didn't hear any immediate complaints and it's been a couple weeks.