feat: Open cerebro window on Active screen #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a reason why this hasn't been merged yet? |
ogustavo-pereira
changed the title
ogustavo-pereira
pushed a commit
that referenced
this pull request
Feb 17, 2022
* Open cerebro window on Active screen * remove blank line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #131.
Instead of using the "Default" display to open Cerebro, it will use the "current" display, based on the cursor position on the screen.
The main functionality is working, but you still see for brief moments, the Cerebro window opened in the previous screen, before appearing on the new screen. A little bit annoying but not a big deal for me.
I also noticed, sometimes I need to press the Hotkey 2 times before Cerebro opens. Not sure if its related with any of the changes I made.
This PR was only tested on Linux but it uses standard Electron functions, so it should work fine elsewhere.