Feature/allow transparency #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Screenshot plugin example without this fix (cerebro window silhouette remains): With this fix (silhouette is gone - and so is the icon, but that's because it's an older screenshot 😛): Quick hacky attempt at a dropshadow proof-of-concept |
|
I could also try again since that was almost a year ago, however I'm blocked by #426 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something odd going on with cached results when I closed the previous PR - this single line is required for allowing plugins to hide the window without losing state (such as for screenshots).
That is, unless the entire system to hide the main window is overhauled.
The moving of CSS from html+body to body wasn't really necessary so I left it as is.