Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUILD]: updating Cerebro core #559

Merged
merged 63 commits into from
Jul 21, 2022
Merged

[BUILD]: updating Cerebro core #559

merged 63 commits into from
Jul 21, 2022

Conversation

dubisdev
Copy link
Contributor

@dubisdev dubisdev commented Jun 22, 2022

Why

Cerebro build system is nowadays outdated: electron v13, babel v6, webpack v3... With this update Cerebro will get more recent dependencies, security updates, possible bug fixes...

Pending tasks

  • Migrated to the last electron version
  • Migrated to webpack v4
  • Migrated to the last eslint version
  • Removed outdated dependencies
  • Created a GH flow for compiling the code for different platforms. (GH actions are free for open source projects!)
  • Configure test script (currently not working in v0.5.0, I deleted all mock files and I'll search for a solution)
  • Update package.json (I changed it to test GH action)
  • Update development docs about two package.json structure and where to add dependencies.

⚠️ BREAKING CHANGES

Possible related issues

@dubisdev dubisdev marked this pull request as ready for review June 27, 2022 19:36
@dubisdev
Copy link
Contributor Author

For now this is ready!
I'm now working in a PR to fix cerebro-basic-apps, but cerebro-ui also needs to be updated, so for now this is all here. Now I'll fix and update the plugins.

image

@dubisdev
Copy link
Contributor Author

Just opened cerebroapp/cerebro-ui#5 to update it and use @electron/remote
Soon I will open a PR for cerebro-basic-apps but first, cerebro-ui must be published so I can use it

@dubisdev
Copy link
Contributor Author

dubisdev commented Jul 1, 2022

With the new version of @cerebroapp/cerebro-ui app icons are back. Some of them are failing but that's an error with cerebro-basic-apps

image

@dubisdev
Copy link
Contributor Author

dubisdev commented Jul 1, 2022

cerebro-basic-apps now working!

image

We need Cerebro to be able to handle @cerebroapp plugin names. As the new version of cerebro-basic-apps wont be compatible with previous cerebro versions (because of the electron version update) I think the best way of not breaking plugins in previous versions is to support from now @cerebroapp/... plugins that will be ignored in previous cerebro versions.

image

@dubisdev
Copy link
Contributor Author

dubisdev commented Jul 2, 2022

I just need cerebro to create @cerebroapp folder in node_modules because it fails if it doesn't exist when installing plugins that start with @cerebroapp

image

@dubisdev
Copy link
Contributor Author

dubisdev commented Jul 3, 2022

Tests are back again 🚀

image

@dubisdev
Copy link
Contributor Author

dubisdev commented Jul 3, 2022

Hi @oguhpereira I think this PR is ready!

Just three last comments:

  • I commented the CI build workflow for macOs as I can not test it. I prefer not releasing an executable if I'm not sure if it will work.
  • I added a section in the readme for documenting how to publish a release. I think we could publish this release as the 1.0.0 and make all our dependencies (cerebo-tools, cerebro-ui) match the mayor version with this, so it will be easier to know which versions are compatible.
  • I didn't lint all the project files for making the PR easier to review. When you are done, I can run the command and then we merge the PR 🙌

image

@ogustavo-pereira
Copy link
Member

@dubisdev this adjustment made me very excited, I uploaded a few small commits here and I'm going to merge. thanks for the contribution

@ogustavo-pereira ogustavo-pereira merged commit eaa59bf into cerebroapp:master Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants