Fix infinite loop in ResteasyContextListener when injector has parent #13
Conversation
| * Processes module bindings in the Guice injector. | ||
| */ | ||
| @VisibleForTesting | ||
| public void processInjector(ServletContext context, Injector injector) { |
There was a problem hiding this comment.
somehow I am not comfortable having this method. Since this is the initial point of a Web application can the Injector that is created in this class even have a parent Injector ? What if we remove this loop completely and just have the processor process the injector that is created in this class ?
There was a problem hiding this comment.
The other way to detect a loop is to use run a fast-slow runner technique to detect the loop in a LinkedList. Seems like a overkill but may be worth trying it.
There was a problem hiding this comment.
I'm not convinced the infinite loop could happen at all or that the while loop is even needed at all. Since the context listener creates the injector is there even any possible way for the injector to have a parent injector?
There was a problem hiding this comment.
Removed the while loop: b666e0a
|
issue #12 |
What was changed? Why is this necessary?
An infinite loop would occur in
ResteasyContextListenerif the Guice injector had a parent injector.How was it tested?
Added new unit test and verified that it resulted in an infinite loop before the fix was implemented.
How to test
This is bare minimum acceptable testing
mvn clean install -UReviewers