This repository has been archived by the owner on May 1, 2024. It is now read-only.
fix for type cast exception while converting from hapi object to avro specific record #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdrillard
suggested changes
Dec 17, 2019
bunsen-avro-records-stu3/pom.xml
Outdated
| @@ -161,7 +161,6 @@ | |||
| <argument>http://hl7.org/fhir/us/core/StructureDefinition/us-core-encounter</argument> | |||
| <argument>http://hl7.org/fhir/us/core/StructureDefinition/us-core-immunization</argument> | |||
| <argument>http://hl7.org/fhir/us/core/StructureDefinition/us-core-medication</argument> | |||
| <argument>http://hl7.org/fhir/us/core/StructureDefinition/us-core-medicationrequest</argument> | |||
There was a problem hiding this comment.
Is there a reason we're removing this resource?
There was a problem hiding this comment.
I was trying to generate an avro class that has contained resource inline instead from maven plugin. As you suggested the prior test is sufficient.
reverted the change 2a1ef48
| resourceTypeUrls | ||
| .put("http://hl7.org/fhir/us/core/StructureDefinition/us-core-medicationrequest", | ||
| ImmutableList.of("http://hl7.org/fhir/StructureDefinition/Provenance")); | ||
|
|
There was a problem hiding this comment.
Since this is part of the tools code (and not really itself testing code), let's remove this addition. The prior test should be sufficient.
| @@ -34,6 +34,7 @@ | |||
| import org.apache.avro.generic.GenericData.Record; | |||
| import org.apache.avro.generic.IndexedRecord; | |||
| import org.apache.avro.specific.SpecificData; | |||
| import org.apache.avro.specific.SpecificRecord; | |||
There was a problem hiding this comment.
Is this a needed import?
There was a problem hiding this comment.
No, removed in 2a1ef48
bdrillard
approved these changes
Dec 17, 2019
|
Merged! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #66, resolving exception.