This repository has been archived by the owner on May 1, 2024. It is now read-only.
issue-77: add Bundles extractEntry Java api with contained resources #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdrillard
suggested changes
Feb 6, 2020
|
|
||
| FhirContext context = FhirContexts.contextFor(fhirVersion); | ||
|
|
||
| this.converter = SparkRowConverter.forResource(context, resourceTypeUrl); | ||
| if (this.containedResourceTypeUrls == null || this.containedResourceTypeUrls.size() == 0) { |
There was a problem hiding this comment.
nit: can we use this.containedResourceTypeUrls.isEmpty() instead?
| public Dataset<Row> extractEntry(SparkSession spark, | ||
| JavaRDD<BundleContainer> bundles, | ||
| Class resourceClass, | ||
| Class... containedClasses) { |
There was a problem hiding this comment.
I think we'll need to make this parameter an explicit list. In practice, Java will have difficulty dispatching between this new method and extractEntry that has the single Class parameter since it can't tell if the call to extractEntry without a final argument is a call without contained classes, or just with empty contained classes.
|
Merged to 0.5.0-dev branch. Thanks for review ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new Java api for
Bundles extractEntryapi to accept contained resources. Closes #71