This repository has been archived by the owner on Apr 16, 2021. It is now read-only.
Added - Scaffolding for unauthorized error handling #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull requests adds the foundation for generic error handling.
The axios interceptors will intercept every request and evaluate the server response / error. If the server responds with an unauthorized status or doesn't respond at all the browser will reload the current page which will force a login.
Additional Details
There is some consideration and discussions for future changes needed for other errors that may need to provide a user with some visual feedback. JS error, internal error, etc...
Ideally 403 errors would be prevented by safeguards in the UI. This pull request will refresh the page on forbidden requests, this should probably be handled in another way in the future. Either by preventing the action entirely in the UI or notifying the user they are not authorized to take that action.
Thanks for contributing to Kaiju.
@cerner/kaiju