This repository has been archived by the owner on May 24, 2024. It is now read-only.
[terra-form-select] Fixed page jump within an Iframe/Embedded Browser #2773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supreethmr
requested review from
dkasper-was-taken,
mjhenkes,
ryanthemanuel,
StephenEsser and
tbiethman
as code owners
supreethmr
requested review from
nramamurth,
avinashg1994,
lokesh-0813,
pranav300 and
saket2403
StephenEsser
changed the title
StephenEsser
reviewed
Dec 6, 2019
| ### Fixed | ||
| * Fixed Page Scroll Issue of form-select. | ||
| * when form-select is used with-in Iframe / Embeded browser clicking on toggle button to open dropdown scrolls page to top of the window. | ||
| * This error was discovered in powerchart application which uses Iframe to render Terra-components. |
There was a problem hiding this comment.
We should remove internal specific implementation from the change log list
There was a problem hiding this comment.
removed : a428f6c
StephenEsser
reviewed
Dec 6, 2019
| @@ -3,6 +3,10 @@ ChangeLog | |||
|
|
|||
| Unreleased | |||
| ---------- | |||
| ### Fixed | |||
| * Fixed Page Scroll Issue of form-select. | |||
There was a problem hiding this comment.
Can these entries be consolidated? Each item in a list should be for a specific change, here there are three asterisks for one entry.
Example:
### Fixed
* Fixed page scrolling when embedded within an iframe
There was a problem hiding this comment.
sure, updated change-log
StephenEsser
approved these changes
Dec 6, 2019
|
@supreethmr can you add the wdio test case for testing this changes using iframe. with tiny or small viewports ? |
ryanthemanuel
approved these changes
Dec 11, 2019
Added here : 5d47bff |
ShettyAkarsh
approved these changes
Dec 13, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #2682
Additional Details
Page jump was happening at two scenarios where one is when single-select is opened before selecting dropdown items and another one is opening form-select when selection has been made.
Focus to menu(dropdown) was setting in opendropdown() method which triggers before PositionDropdown causing page to scroll to the top on form-select open.
scrollIntoView() is called to scroll into active option on dropdown open. ScrollIntoView causes page Jump as shown in Issue when used within Iframe. Hence replaced ScrollIntoView with ScrollTop of menu ( dropdown ).