This repository has been archived by the owner on May 24, 2024. It is now read-only.
Alias moment and react-dom #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matt-Butler
commented
May 2, 2017
| alias: { react: path.resolve(__dirname, 'node_modules', 'react') }, | ||
| alias: { 'react$': path.resolve(__dirname, 'node_modules', 'react') }, | ||
| alias: { 'react-dom$': path.resolve(__dirname, 'node_modules', 'react') }, | ||
| alias: { 'moment$': path.resolve(__dirname, 'node_modules', 'moment') }, |
There was a problem hiding this comment.
Matt-Butler
force-pushed
the
alias-webpack
branch
2 times, most recently
from
aae1ec1
to
9213b96
Compare
JakeLaCombe
approved these changes
May 3, 2017
mjhenkes
approved these changes
May 4, 2017
bjankord
approved these changes
May 4, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After adding the alias for moment and react-dom, we can see that only one copy is pulled into our bundle.
Before:
After
These images were generated using https://github.com/th0r/webpack-bundle-analyzer
Making this update
terra-core.js 5.62 MB
to
terra-core.js 4.61 MB
Thanks for contributing to Terra.
@cerner/terra