Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

[terra-embedded-content-consumer] Updated the path name for the examples in doc site to resolve missing files #1695

Merged
merged 3 commits into from
Jul 13, 2023

Conversation

kolkheang
Copy link
Member

Summary

What was changed:
Updated the path name of the dependency file which uses in the examples in terra-embedded-content-consumer

Why it was changed:
The update is needed to resolve the 404 missing file

Testing

This change was tested using:

  • WDIO
  • Jest
  • Visual testing (please attach a screenshot or recording)
  • Other (please describe below)
  • No tests are needed

Reviews

In addition to engineering reviews, this PR needs:

  • UX review
  • Accessibility review
  • Functional review

Additional Details

Screenshot 2023-07-11 at 1 18 26 PM Screenshot 2023-07-11 at 1 18 41 PM

This PR resolves:

UXPLATFORM-9302


Thank you for contributing to Terra.
@cerner/terra

@kolkheang
Copy link
Member Author

kolkheang commented Jul 11, 2023

Looking at the PR build for docs, there are still 404s
https://engineering.cerner.com/terra-framework/pull/1695/. Perhaps, the path is still not correct when looking at the PR build.

Running the site locally, the examples works fine after the update.

@github-actions github-actions bot temporarily deployed to preview-pr-1695 July 12, 2023 17:31 Destroyed
@kolkheang
Copy link
Member Author

I fixed the new issue by including /terra-framework/ prefix in the path.

@vinaybhargavar
Copy link
Contributor

I fixed the new issue by including /terra-framework/ prefix in the path.

I see the content is now updated on the deployed site.
Screen Shot 2023-07-12 at 3 41 48 PM

@kolkheang
Copy link
Member Author

@scottwilmarth - FYI - this is just to get the examples working again

@sdadn / @sycombs - can you merge?

@sycombs sycombs merged commit a987775 into main Jul 13, 2023
@sycombs sycombs deleted the update-example-files-path-for-embedded-content-consumer branch July 13, 2023 15:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants