Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring of CLI and Configure alternative server URL #32

Merged
merged 1 commit into from
Sep 4, 2020
Merged

Refactoring of CLI and Configure alternative server URL #32

merged 1 commit into from
Sep 4, 2020

Conversation

ParthS007
Copy link
Member

@ParthS007 ParthS007 commented Sep 2, 2020 •
edited
Loading

closes #31
closes #20

tiborsimko
tiborsimko reviewed Sep 2, 2020
View reviewed changes
Copy link
Member

@tiborsimko tiborsimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well, left a few comments about putting server as first parameter to all functions, and about validating the passed value so that users won't see so much Python traceback in case of wrong user input.

.gitignore Show resolved Hide resolved
cernopendata_client/cli.py Outdated Show resolved Hide resolved
cernopendata_client/cli.py Outdated Show resolved Hide resolved
cernopendata_client/cli.py Outdated Show resolved Hide resolved
cernopendata_client/cli.py Outdated Show resolved Hide resolved
cernopendata_client/opendata_analysis_query.py Show resolved Hide resolved
cernopendata_client/search.py Outdated Show resolved Hide resolved
global: code refactoring
f89702f 
deprecate opendata_analysis_query closes #20
add configuration for setting alternative server URL closes #31
@tiborsimko tiborsimko merged commit f89702f into cernopendata:master Sep 4, 2020
@tiborsimko tiborsimko mentioned this pull request Sep 4, 2020
Closed
@ParthS007 ParthS007 deleted the refactor branch September 4, 2020 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiborsimko tiborsimko tiborsimko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

configuration: allow setting alternative server URL deprecate opendata_analysis_query.py
2 participants
@ParthS007 @tiborsimko