Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate Kubernetes Events #10

Merged
merged 3 commits into from
Jun 1, 2023
Merged

Generate Kubernetes Events #10

merged 3 commits into from
Jun 1, 2023

Conversation

wallrj
Copy link
Member

@wallrj wallrj commented Mar 26, 2021 •
edited
Loading

Added Event recorder to each reconciler and updated unit-tests to check the Event behaviour.

Fixes: #4

@jetstack-bot jetstack-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 26, 2021
@wallrj wallrj force-pushed the 4-events branch 5 times, most recently from b7eb09c to cd8c4f8 Compare March 26, 2021 16:44
@wallrj wallrj changed the title WIP: Generate Kubernetes Events Generate Kubernetes Events Mar 26, 2021
@wallrj wallrj marked this pull request as ready for review March 26, 2021 16:46
@jetstack-bot jetstack-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 26, 2021
@jetstack-bot jetstack-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 14, 2021
@inteon inteon self-assigned this Jun 1, 2023
wallrj and others added 3 commits June 1, 2023 11:11
@wallrj @inteon
Generate Kubernetes Events
77bee86 
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
@wallrj @inteon
Add notes about Event generation to the documentation
9d7c07c 
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
@inteon
fix remaining bug
3530e09 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@jetstack-bot jetstack-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 1, 2023
@inteon
Copy link
Member

inteon commented Jun 1, 2023

/approve
/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 1, 2023
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon, wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot merged commit 0f90db4 into cert-manager:main Jun 1, 2023
@wallrj wallrj deleted the 4-events branch October 24, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@inteon inteon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Kubernetes Events logging significant operations and errors
3 participants
@wallrj @inteon @jetstack-bot