Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it obvious that the cert-manager Pod presets are applied for all tests #411

Closed
wallrj opened this issue Jan 15, 2021 · 0 comments · Fixed by #432
Closed

Make it obvious that the cert-manager Pod presets are applied for all tests #411

wallrj opened this issue Jan 15, 2021 · 0 comments · Fixed by #432

Comments

@wallrj
Copy link
Member

wallrj commented Jan 15, 2021

The Pod presets are currently in cert-manager-presubmits.yaml but we should move them to a separate file to make it obvious that they are used by other tests too. See: #409 (comment)
@wallrj wallrj changed the title Make it obviouse that the cert-manager Pod presets are applied for all tests Make it obvious that the cert-manager Pod presets are applied for all tests Jan 15, 2021
wallrj added a commit to wallrj/testing that referenced this issue Jan 15, 2021
@wallrj
A note about the scope of the Pod presets
83aee92 
See cert-manager#411

Signed-off-by: Richard Wall <richard.wall@jetstack.io>
@wallrj wallrj mentioned this issue Feb 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move the cert-manager pod presets into a config.yaml wallrj/testing
1 participant
@wallrj