Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better handling of local arch differences #250

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Better handling of local arch differences #250

merged 2 commits into from
Nov 30, 2023

Conversation

SgtCoDFish
Copy link
Member

These commits help when developing on non-amd64 architectures.

@SgtCoDFish
use local arch for load target rather than hardcoded amd64
0e851ad 
this improves the experience on, say, arm64

Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 29, 2023
@SgtCoDFish SgtCoDFish mentioned this pull request Nov 29, 2023
Merged
inteon
inteon reviewed Nov 29, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
inteon
inteon reviewed Nov 29, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@SgtCoDFish
improve build target comment to make clear we'll use the local arch
1813050 
Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
@jetstack-bot jetstack-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 29, 2023
@SgtCoDFish
Copy link
Member Author

/test pull-trust-manager-smoke

@inteon
Copy link
Member

inteon commented Nov 30, 2023

/approve
/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2023
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2023
@jetstack-bot jetstack-bot merged commit 443fc94 into cert-manager:main Nov 30, 2023
4 checks passed
@SgtCoDFish SgtCoDFish deleted the localarch branch January 2, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inteon inteon inteon left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SgtCoDFish @inteon @jetstack-bot