Use the go version specified in the Makefile tools module #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
cert-manager-prow
bot
added
dco-signoff: yes
inteon
commented
May 29, 2024
|
|
||
| - id: release | ||
| run: make release | ||
|
|
||
| - uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: trust-manager-${{ env.VERSION }}.tgz | ||
| name: ${{ steps.release.outputs.RELEASE_HELM_CHART_NAME }}-${{ steps.release.outputs.RELEASE_HELM_CHART_VERSION }}.tgz |
There was a problem hiding this comment.
This change is also based on https://github.com/cert-manager/approver-policy/blob/main/.github/workflows/release.yaml.
|
/lgtm |
SgtCoDFish
approved these changes
May 29, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SgtCoDFish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cert-manager-prow
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed that the go version used to release trust-manager v0.10.0 did not match the go version specified in the
toolsMakefile module.This is due to an oversight in the release.yaml GH action definition. This PR updates those yaml files to match the logic we are using in other projects (eg. approver-policy, see https://github.com/cert-manager/approver-policy/blob/main/.github/workflows/release.yaml).