re-add support for s390x #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cert-manager#315 we added support for s390x, but this was unintentionally removed in v0.10.0 due to the makefile modules changes. This PR re-adds support for s390x. It depended on a new base image being built for s390x, which wasn't previously created. Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
cert-manager-prow
bot
added
dco-signoff: yes
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SgtCoDFish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cert-manager-prow
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #315 we added support for s390x, but this was unintentionally removed in v0.10.0 due to the makefile modules changes. This PR re-adds support for s390x.
It depended on a new base image being built for s390x (via cert-manager/base-images#5), which wasn't previously available.
Confirmed locally that
make oci-build-manager oci-build-package_debianbuilds s390x versions of both.