Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asn_lookup update script FTP vs HTTP #1535

Closed
ghost opened this issue May 14, 2020 · 3 comments
Closed

asn_lookup update script FTP vs HTTP #1535

ghost opened this issue May 14, 2020 · 3 comments
Labels
bug Indicates an unexpected problem or unintended behavior component: bots component: contrib
Milestone

Comments

@ghost
Copy link

ghost commented May 14, 2020

The current asn_lookup / pyasn update script uses FTP to fetch the database from archive.routeviews.org, but we only used http(s)_proxy yet. So this won't work in some environments (including @certat's). So fixing hadiasghari/pyasn#62 would still be nice, or alternatively hadiasghari/pyasn#64

@ghost ghost added bug Indicates an unexpected problem or unintended behavior component: bots component: contrib labels May 14, 2020
@ghost ghost added this to the 2.1.3 milestone May 14, 2020
@gethvi
Copy link
Contributor

gethvi commented May 16, 2020

Given the pyasn package is not currently maintained, a completely different option is to use GeoLite2 ASN and have maxmind_asn expert bot. However I can not say which one of the data sources is better in terms of quality.

Pros:

  • reliable source and maintained geoip package
  • one less dependency (because geoip package is already being used by other bot)

Cons:

  • new bot needs to be implemented (but we already have almost the same code)

@ghost
Copy link
Author

ghost commented May 20, 2020

Are you sure that the GeoLite2 database has a good enough ASN-IP address mapping?

With pyasn you can use any BGP routing table which makes you very independent from (one) external data source(s).

@ghost ghost modified the milestones: 2.1.3, 2.2.0 May 20, 2020
@ghost ghost modified the milestones: 2.2.0, 2.3.0 Jun 17, 2020
@ghost
Copy link
Author

ghost commented Sep 4, 2020

fixed by #1524

@ghost ghost closed this as completed Sep 4, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior component: bots component: contrib
Projects
None yet
Development

No branches or pull requests

1 participant