JSON-RPC error messages #61
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes try to align the error messages generated in the mjson jsonrpc handler with the error messages in the JSON-RPC 2.0 Specification. An example of such behavior is seen in #60.
Additionally, while writing tests for this new functionality using the existing test pattern, I observed a situation where some tests for the jsonrpc functionality would pass even when they contained an intentional error. When there were two consecutive tests that produced the same output string, the second test would not fail (when it should have) because the call to
ASSERTwould compare strings using the output string from the previous unit test without first checking the length. Since the length is set to zero before each test, it should be tested usingASSERTbefore performing a string comparison.