Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove git dependancy in package.json #14

Closed
mramato opened this issue Jul 1, 2016 · 0 comments
Closed

Remove git dependancy in package.json #14

mramato opened this issue Jul 1, 2016 · 0 comments

Comments

@mramato
Copy link
Contributor

mramato commented Jul 1, 2016

  1. We should never use a git dependancy without a specific hash appended to it, otherwise you end up just using whatever is in master wen you npm install.
  2. We should never merge a package.json with git references to master. Package in master should either be published npm modules or git submodules.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants