-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add silent mode #2
Conversation
support -s flag for silent mode, which continues to process even when a dependency is not found locally useful for using deplist to build a list of potentially missing dependencies suitable for shoving into `go get`.
Interesting. The only problem I have which this is that what you get back depends on what's currently loaded on your machine. If you only depend on one package, but that has 100 transitive dependences, then whether you get 1 or 101 results from deplist depends on whether you have that package available. I feel like what you actually want is a way to force maxdepth = 1 (maybe |
@cespare Thanks for the response! I'm still trying to fully grok the details of how I thought that "what you get back depends on what's currently loaded on your machine" was necessary in order to properly feed a list of packages into My worry was the case where a direct dependency updates one of it's transitive dependencies. But maybe |
From glancing at the terraform issue, it seems like you guys are doing something special/fancy with your dependencies. In any case, I don't see how the list you get with |
I looked at your Makefile more closely. I understand what's happening now. You basically just want (You should also consider using godep or similar for such a project, to lock dependency versions, so that you get more reproducible builds.) |
@cespare so our problem was with travis builds was that |
|
Cool, after some fiddling, this seems to do what I need:
Thanks for the help! |
After discussing with the very gracious @cespare over at cespare/deplist#2 I now understand that we can pull off the same logic with just `go list`. The logic is now simpler and more consistent: * List out all packages in our repo * For each of those packages, list their dependencies * Filter out any dependencies that already live in this repo * Remove duplicates * And fetch the rest. `go get` will work out all transitive dependencies from there
Glad I could help :) |
After discussing with the very gracious @cespare over at cespare/deplist#2 I now understand that we can pull off the same logic with just `go list`. The logic is now simpler and more consistent: * List out all packages in our repo * For each of those packages, list their dependencies * Filter out any dependencies that already live in this repo * Remove duplicates * And fetch the rest. `go get` will work out all transitive dependencies from there
👋 Cool little tool you've got here!
I'm trying it out to solve a problem we're seeing over in hashicorp/terraform#901, but I had to add this feature to make it do what we needed.
For now we can point to my fork, but let me know if you're interested in pulling this in. 👍
support -s flag for silent mode, which continues to process even when a
dependency is not found locally
useful for using deplist to build a list of potentially missing
dependencies suitable for shoving into
go get
.