This repository has been archived by the owner on Sep 18, 2019. It is now read-only.
Don't create extra flag namespaces for embedded fields #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to how endoding/json handles embedded structs. This is also how BurntSushi/toml handles them so it makes sense to have corresponding flag names.
| @@ -182,6 +182,9 @@ In TOML, a struct corresponds to a nested section; in flags the name will be dot | |||
| // and this flag | |||
| -s.n=3 | |||
|
|
|||
| Embedded structs are handled similarly to encoding/json: fields of embedded | |||
| struct are treated as if they were fields of embedding struct. | |||
There was a problem hiding this comment.
Wording tweaks:
Embedded structs are handled like in encoding/json: their exported fields
are treated as if they were fields of the outer struct.
|
Nice, good find. LGTM. |
awly
pushed a commit
that referenced
this pull request
May 21, 2015
Don't create extra flag namespaces for embedded fields
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to how endoding/json handles embedded structs. This is also how
BurntSushi/toml handles them so it makes sense to have corresponding
flag names.
Sorry for the noise in tests, had to rename existing
embeddedtonestedto avoid confusion.