Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflex now requires Go version v1.13 or higher #85

Closed
okybr opened this issue Aug 31, 2021 · 1 comment
Closed

Reflex now requires Go version v1.13 or higher #85

okybr opened this issue Aug 31, 2021 · 1 comment

Comments

@okybr
Copy link

okybr commented Aug 31, 2021

The lastest commit -- 13e5691 -- uses errors.Is (from the errors package) which was introduced with Go version v1.13. (You can compare the documentation of the different versions like https://pkg.go.dev/errors@go1.13.) But the README of this package still states that it only requires v1.11. Thus, there's a contradiction which can be resolved

  • either by requiring at least Go version v1.13 and adjust the README; or
  • modify reflex.go again so that it does not use errors.Is so that this package still works with Go v1.11.

As the service ran by my company does not yet use v1.13, we'd prefer you to choose the second way.

@cespare
Copy link
Owner

cespare commented Aug 31, 2021

I'd rather keep using the new features. I updated the installation instructions in the README.

I've added binary downloads to the Releases page so you can install that way if you wish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants