Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Fix nifi template userguide and add testing of grafana and adminer services. #107

Closed
wants to merge 54 commits into from
Closed

Fix nifi template userguide and add testing of grafana and adminer services. #107

wants to merge 54 commits into from

Conversation

fzalila
Copy link
Contributor

@fzalila fzalila commented Feb 24, 2020

Fix #105.

Faiez Zalila and others added 30 commits October 21, 2019 17:28
Setup the testing framework for fadi.
4d430f3
First commit of Fadi tests.
a3bd80f
Reorganize the tests repository.
30a3290
Merge branch 'feature/tests' of https://github.com/cetic/fadi.git into
7c4ff34 
feature/tests

Conflicts:
	tests/testing-project/jest.config.js
	tests/testing-project/lib/config.js
	tests/testing-project/lib/helpers.js
	tests/testing-project/package.json
A new reorganisation of tests forlder.
d2b94f4
Update package.json and remove unused require.
6a3de89
Add missed configuration files.
b692f18
Test upload Nifi template feature.
3f8003d
Adding the cockburns and test scripts specification in the repository…
fdc9f77 
… fadi/tests/doc and a Readme for the test
@SellamiRami
Adding the links to the tes scripts specifications
786eb76
Adding the test scripts repository
6175c2d
Merge branch 'feature/testsDOC' of https://github.com/cetic/fadi into…
90541da 
… feature/testsDOC
@SellamiRami
Adding links to the test scripts in the table
4433ff5
@SellamiRami
Update Test-scripts-specifications.md
1f5892a
@SellamiRami
Rename Cockburns-specification to Cockburns-specification.md
8c5f68b
@SellamiRami
Update Cockburns-specification.md
9a7efa4
@SellamiRami
Update Cockburns-specification.md
696a413
Adding the cockburn repository
b6f5313
@SellamiRami
Update TC-18.md
60ef775
@SellamiRami
Update TC-19.md
443229d
@SellamiRami
Update TC-20.md
eb727f1
@SellamiRami
Update TC-21.md
a340d01
@SellamiRami
Update TC-21.md
d161996
@SellamiRami
Adding a README file for the doc repository
d0260ae
@SellamiRami
Delete README.md
2ca931b
@SellamiRami
Adding a README file for the tests repository
969e1bc
@SellamiRami
Adding a template to create a new test case
ae72716
@SellamiRami
Adding a template to create a new test script
4d1509c
@SellamiRami
Defining a README for the test repository
b79b03c
@SellamiRami
Update README.md
310553a
@banzo
Copy link
Contributor

banzo commented Feb 26, 2020

@fzalila This PR seems to do more than fix issue 105, does it also include all the brand new automated testing?

@banzo banzo self-requested a review February 26, 2020 12:52
@banzo banzo linked an issue Feb 26, 2020 that may be closed by this pull request
Nifi template of the userguide shows an error #105
Closed
@fzalila fzalila changed the title Fix/nifi template userguide Fix nifi template userguide and add testing of grafana and adminer services. Feb 27, 2020
@fzalila
Copy link
Contributor Author

fzalila commented Feb 27, 2020

@banzo yes it includes tests of grafana and adminer services. I updated the title to reflect that.

@banzo banzo added documentation enhancement New feature or request labels Mar 2, 2020
@banzo
Copy link
Contributor

banzo commented Mar 3, 2020 •
edited
Loading

Some comments:

  • __tests__:
    • some helpers defined in the test scripts do not seem to be used (ex loadUrl, waitForText, ...), are they necessary?
    • nt4s url needs to be removed, this should preferably be a config variable somewhere (lib/config.js baseUrl?), you can use http://test.fadi.cetic.be as a placeholder.
    • if possible, use the test case identifier in the filename instead of introducting a new numerotation
  • provide examples in README.md
  • Test-scripts-specifications.md :
    • links should be relative, not absolute
    • some links are missing
  • Cockburns-specifications.md :
    • some links are missing
  • remove remaining pgadmin references

@banzo banzo added this to the 0.1.2 milestone Mar 6, 2020
@fzalila fzalila closed this Mar 27, 2020
@fzalila fzalila mentioned this pull request Mar 27, 2020
Open
@banzo banzo deleted the fix/nifi_template_userguide branch November 15, 2021 10:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@banzo banzo Awaiting requested review from banzo

Assignees

@fzalila fzalila

Labels
documentation enhancement New feature or request
Projects
None yet
Milestone
0.1.2
Development

Successfully merging this pull request may close these issues.

Nifi template of the userguide shows an error
3 participants
@fzalila @banzo @SellamiRami