Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

[cetic/nifi] Make helm chart compatible with apache/nifi >= 1.19.0 #313

Closed
jrebmann opened this issue Sep 27, 2023 · 3 comments · Fixed by #314
Closed

[cetic/nifi] Make helm chart compatible with apache/nifi >= 1.19.0 #313

jrebmann opened this issue Sep 27, 2023 · 3 comments · Fixed by #314
Labels
enhancement New feature or request

Comments

@jrebmann
Copy link
Contributor

Problem description:

I like to run the latest apache/nifi container version 1.23.2 in my kubernetes cluster.
The last working nifi version is 1.18.0.

Analysis:

Since apache/nifi 1.19.0 docker container uses java 11.
When changing to this Java version there was a breaking change: The default keystore type changed from JKS to PKCS12.
Source: https://bugs.openjdk.org/browse/JDK-8178828

This change causes cetic/helm-nifi to ignore all certificates set via cert-manager and caSecrets.

Solution:

Set the keystore type explicitly to JKS on importing the certificates by adding -storetype JKS or -deststoretype JKS to the keytool command.

The advantage of this solution is that it is backward compatible and thus works on for java 8.
jrebmann added a commit to jrebmann/helm-nifi that referenced this issue Sep 27, 2023
@jrebmann
Make compatible with apache/nifi >= 1.19.0 (cetic#313)
c4d8873
jrebmann added a commit to jrebmann/helm-nifi that referenced this issue Sep 27, 2023
@jrebmann
Make compatible with apache/nifi >= 1.19.0 (cetic#313)
cd49987 
Signed-off-by: Jannik Rebmann <jannik.rebmann@ise.fraunhofer.de>
jrebmann added a commit to jrebmann/helm-nifi that referenced this issue Sep 27, 2023
@jrebmann
Make compatible with apache/nifi >= 1.19.0 (cetic#313)
02b44c8 
Signed-off-by: Jannik Rebmann <jannik.rebmann@ise.fraunhofer.de>
jrebmann pushed a commit to jrebmann/helm-nifi that referenced this issue Sep 27, 2023
@combineads @jrebmann
Make compatible with apache/nifi >= 1.19.0 (cetic#313)
08925a1 
Signed-off-by: Jannik Rebmann <jannik.rebmann@ise.fraunhofer.de>
jrebmann pushed a commit to jrebmann/helm-nifi that referenced this issue Sep 27, 2023
@combineads @jrebmann
Make compatible with apache/nifi >= 1.19.0 (cetic#313)
143e76b 
Signed-off-by: Jannik Rebmann <jannik.rebmann@ise.fraunhofer.de>
jrebmann added a commit to jrebmann/helm-nifi that referenced this issue Sep 27, 2023
@jrebmann
Make compatible with apache/nifi >= 1.19.0 (cetic#313)
d01dfe0 
Signed-off-by: Jannik Rebmann <jannik.rebmann@ise.fraunhofer.de>
jrebmann added a commit to jrebmann/helm-nifi that referenced this issue Sep 27, 2023
@jrebmann
Make compatible with apache/nifi >= 1.19.0 (cetic#313)
bed877f 
Signed-off-by: Jannik Rebmann <jannik.rebmann@ise.fraunhofer.de>
jrebmann added a commit to jrebmann/helm-nifi that referenced this issue Sep 27, 2023
@jrebmann
Make compatible with apache/nifi >= 1.19.0 (cetic#313)
f64375a 
Signed-off-by: Jannik Rebmann <jannik.rebmann@ise.fraunhofer.de>
@jrebmann jrebmann mentioned this issue Sep 27, 2023
Merged
2 tasks
@jrebmann
Copy link
Contributor Author

I created a pull request #314 to make it compatible with apache/nifi >= 1.19.0.

@github-actions GitHub Actions
Copy link

This issue is stale because it has not seen recent activity. Remove stale label or comment or this will be closed.

@github-actions github-actions bot added the stale No recent activity, will be closed unless label removed label Nov 27, 2023
@banzo banzo removed the stale No recent activity, will be closed unless label removed label Nov 27, 2023
@jrebmann
Copy link
Contributor Author

The PR for this issue is essential to get in sync with the latest Apache NiFi versions.

@banzo banzo added the enhancement New feature or request label Nov 30, 2023
banzo added a commit that referenced this issue Dec 20, 2023
@jrebmann @banzo
Make compatible with apache/nifi >= 1.19.0 (#313) (#314)
89857aa 
* Make compatible with apache/nifi >= 1.19.0 (#313)

Signed-off-by: Jannik Rebmann <jannik.rebmann@ise.fraunhofer.de>

* trigger GitHub actions

* trigger GitHub actions

---------

Signed-off-by: Jannik Rebmann <jannik.rebmann@ise.fraunhofer.de>
Co-authored-by: Sebastien Dupont <dupont.sebastien@gmail.com>
@jrebmann jrebmann mentioned this issue Feb 7, 2024
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make compatible with apache/nifi >= 1.19.0 (#313) jrebmann/helm-nifi
2 participants
@banzo @jrebmann