Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does ttypescript now support new ts version 5.x.x #147

Open
hi-zhaolei opened this issue Apr 13, 2023 · 6 comments
Open

Does ttypescript now support new ts version 5.x.x #147

hi-zhaolei opened this issue Apr 13, 2023 · 6 comments

Comments

@hi-zhaolei
Copy link

hi-zhaolei commented Apr 13, 2023

After upgrade typescript to 5.0.4 in project. the build script excuted error like below.

image

Does anyone know how to solve this? It seems like ts tsm api change to proxy object.

@samchon
Copy link
Contributor

samchon commented Apr 13, 2023

This project seems dead

@nonara
Copy link
Contributor

nonara commented Apr 13, 2023

ts-patch is a replacement for ttypescript w/ v5+ support

See: ts-patch

@hi-zhaolei
Copy link
Author

@nonara
Wow, I haven't heard of this package before, I think I can try it out.
Reply later...

@samchon
Copy link
Contributor

samchon commented Apr 13, 2023

@nonara When the ts-patch v3 would be published? I think publishing v3 first and fixing ts-node later would be better.

@hi-zhaolei
Copy link
Author

@nonara Uh... the previous error solved, but there is a new problem. I don't know if there's something wrong with my usage. I'll reply directly to the linked issue.

@mindplay-dk
Copy link

Latest beta of ts-patch worked with TS 5 for me! 👍

See this issue and author's notes.

sungik-choi added a commit to channel-io/bezier-react that referenced this issue Mar 21, 2024
<!--
  How to write a good PR title:
- Follow [the Conventional Commits
specification](https://www.conventionalcommits.org/en/v1.0.0/).
  - Give as much context as necessary and as little as possible
  - Prefix it with [WIP] while it’s a work in progress
-->

## Self Checklist

- [x] I wrote a PR title in **English** and added an appropriate
**label** to the PR.
- [x] I wrote the commit message in **English** and to follow [**the
Conventional Commits
specification**](https://www.conventionalcommits.org/en/v1.0.0/).
- [x] I [added the
**changeset**](https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md)
about the changes that needed to be released. (or didn't have to)
- [x] I wrote or updated **documentation** related to the changes. (or
didn't have to)
- [x] I wrote or updated **tests** related to the changes. (or didn't
have to)
- [x] I tested the changes in various browsers. (or didn't have to)
  - Windows: Chrome, Edge, (Optional) Firefox
  - macOS: Chrome, Edge, Safari, (Optional) Firefox

## Related Issue
<!-- Please link to issue if one exists -->

- Fixes #1748 
- Fixes #1432 

## Summary
<!-- Please brief explanation of the changes made -->

- https://github.com/channel-io/shared-configs 팀 공용 설정 파일을 바탕으로 configs/
하위에 레포지토리 공용 eslint, typescript config를 설정합니다.
  - supports/ 하위보다 더 명확한 디렉토리명이라고 판단하여 이름 변경
- 전반적으로 중복되는 설정들을 공용 설정으로 이동하고 제거했습니다.

## Details
<!-- Please elaborate description of the changes -->

- eslint의 import/order 규칙을 단순하게 통일하게 되면서 일부 order 변경이 있습니다
- 브라우저용/노드용 패키지를 구분하여 typescript config를 만들었습니다.
- tsconfig의 include 패턴에 와일드카드를 사용하여 단순화했습니다. 와일드 카드를 사용할 필요가 없는 케이스도
마찬가지로 단순화했습니다. (`src/**/*` -> `src`)
- tsconfig의 exclude 패턴에 불필요한 패턴을 정리했습니다 (예: node_modules)
- typescript 버전을 v5.4로 업데이트합니다.
  - `ttypescript` : 패키지가 v5와 호환되지 않아서 ts-patch 라이브러리로 대체합니다
  - cevek/ttypescript#147

### Breaking change? (Yes/No)
<!-- If Yes, please describe the impact and migration path for users -->

No

## References
<!-- Please list any other resources or points the reviewer should be
aware of -->

- https://github.com/channel-io/shared-configs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants