Teach tom to add tags #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 1, 2020 13:19
Instead of one remote with different URLs for push and pull, we now have two remotes: `upstream` and `origin`, so you could easily push directly to upstream remote - useful when pushing tags, since we don't (can't?) create pull requests for them.
olehermanse
reviewed
Apr 5, 2020
| @@ -7,7 +7,7 @@ | |||
| "reviewers": ["olehermanse", "vpodzime"], | |||
| "jenkins": "https://ci.cfengine.com/", | |||
| "jenkins_job": "pr-pipeline", | |||
| "bot_features": ["create_pr_magic", "update_dependencies", "generate_changelogs", "ping_reviewer"], | |||
| "bot_features": ["create_pr_magic", "update_dependencies", "generate_changelogs", "ping_reviewer", "tag_builds"], | |||
There was a problem hiding this comment.
@Lex-2008 This config is for the instance of tom running on jenkins machine. I believe it should not have any of the slack features, since you are running this elsewhere?
olehermanse
reviewed
Apr 5, 2020
| @@ -47,6 +47,8 @@ def __init__(self, config, secrets, directory, interactive): | |||
| if 'generate_changelogs' in config["bot_features"]: | |||
| self.changelogger = ChangelogGenerator( | |||
| self.github, self.slack, self.dispatcher, 'Lex-2008') | |||
| if 'tag_builds' in config["bot_features"]: | |||
| self.tagger = Tagger(self.github, self.slack, self.dispatcher, 'Lex-2008') | |||
There was a problem hiding this comment.
Please talk to @nickanderson about not using a personal account for this.
olehermanse
reviewed
Apr 5, 2020
| def push(self, branch_name): | ||
| """Pushes local branch to remote repo, optionally also setting upstream | ||
| def push(self, ref=None, remote='origin'): | ||
| """Pushes local branch or tag to remote repo, optionally also setting it as upstream |
cf-bottom
approved these changes
Apr 5, 2020
cf-bottom
approved these changes
Apr 5, 2020
cf-bottom
approved these changes
Apr 5, 2020
cf-bottom
approved these changes
Apr 5, 2020
Lex-2008
pushed a commit
to Lex-2008/cf-bottom
that referenced
this pull request
Sep 21, 2020
It was added in cfengine#54, but wasn't enabled by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.