-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extensive refactor for v1.0 release #212
Conversation
Currently translated at 12.5% (21 of 168 strings) Translation: PDFStitcher/PDFStitcher Translate-URL: https://hosted.weblate.org/projects/pdfstitcher/user-interface/sv/
Currently translated at 72.0% (121 of 168 strings) Translation: PDFStitcher/PDFStitcher Translate-URL: https://hosted.weblate.org/projects/pdfstitcher/user-interface/tr/
Currently translated at 82.7% (139 of 168 strings) Translation: PDFStitcher/PDFStitcher Translate-URL: https://hosted.weblate.org/projects/pdfstitcher/user-interface/it/
Currently translated at 100.0% (168 of 168 strings) Translation: PDFStitcher/PDFStitcher Translate-URL: https://hosted.weblate.org/projects/pdfstitcher/user-interface/it/
Currently translated at 65.4% (110 of 168 strings) Translation: PDFStitcher/PDFStitcher Translate-URL: https://hosted.weblate.org/projects/pdfstitcher/user-interface/cs/
Currently translated at 100.0% (168 of 168 strings) Translation: PDFStitcher/PDFStitcher Translate-URL: https://hosted.weblate.org/projects/pdfstitcher/user-interface/tr/
Currently translated at 100.0% (168 of 168 strings) Translation: PDFStitcher/PDFStitcher Translate-URL: https://hosted.weblate.org/projects/pdfstitcher/user-interface/hi/
Currently translated at 100.0% (168 of 168 strings) Translation: PDFStitcher/PDFStitcher Translate-URL: https://hosted.weblate.org/projects/pdfstitcher/user-interface/hi/
Currently translated at 97.0% (163 of 168 strings) Translation: PDFStitcher/PDFStitcher Translate-URL: https://hosted.weblate.org/projects/pdfstitcher/user-interface/fr/
Currently translated at 44.0% (74 of 168 strings) Translation: PDFStitcher/PDFStitcher Translate-URL: https://hosted.weblate.org/projects/pdfstitcher/user-interface/pl/
Currently translated at 99.4% (167 of 168 strings) Translation: PDFStitcher/PDFStitcher Translate-URL: https://hosted.weblate.org/projects/pdfstitcher/user-interface/nl/
Currently translated at 51.7% (87 of 168 strings) Translation: PDFStitcher/PDFStitcher Translate-URL: https://hosted.weblate.org/projects/pdfstitcher/user-interface/pl/
Currently translated at 100.0% (168 of 168 strings) Translation: PDFStitcher/PDFStitcher Translate-URL: https://hosted.weblate.org/projects/pdfstitcher/user-interface/hi/
Trim with mixed units still not behaving
@cfcurtis Thanks for the info, great to see how this project keeps going! |
Refactoring changes
The codebase was refactored to further separate GUI elements from the processing functionality and add more command line support. The code is now structured as follows:
ProcessingBase
, an abstract base class for each processing unitProcessingBase
class to manage sub-units and communicate with the GUI/CLItile_pages.py
(the original single script version of PDFStitcher!), providing thePageTiler
processing unit classProcessingBase
classesThe following refactoring changes have also been made:
_funcname
convention, with most processing units only defining arun
method to be called from the GUI/CLIpx
renamed topt
to more accurately reflect the PDF base unitBug fixes and changes
Build system changes
macos-12
as 11 has lost support :(@mara004 I know you've been away from this project for some time, but I wanted to specifically point out the CLI changes as you did a lot of work in adapting the page tiling stuff. It's not gone, it's just moved to cli/app.py. I'm guessing you've adapted it for your own uses by now, but I wanted to let you know as it's a breaking change.