Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FailCheck #79

Closed
mdzik opened this issue Jun 29, 2016 · 3 comments
Closed

FailCheck #79

mdzik opened this issue Jun 29, 2016 · 3 comments
Assignees

Comments

@mdzik
Copy link
Member

mdzik commented Jun 29, 2016

I found that FailCheck is not working

The xml file looks like this:

<Solve Iterations="100000">
<VTK Iterations="100" />
<Failcheck Iterations="50">
<VTK />
</Failcheck>
</Solve>

I get this error:

There IS complete NaN Rho field, but: on BC (left/right) it's not, so

                if (!cond) {
                        real_t tmp;
                        solver->lattice->GetRho(reg,&tmp);
                        cond = (std::isnan(tmp));

is OK, because temp is first element of Rho array, which is BC, and not NaN

@shkodm I will fix that, but do we want 2 separate versions? Is this a bug or a future? :)

@shkodm
Copy link
Member

shkodm commented Jun 29, 2016

It was intended behaviour of FailCheck, that it checks only top right corner of the mesh(es).If NaN's hasn't propagated there, it will not work. Probably it's good idea to allow user to specify sampling point for it, as </Failcheck dx="3" dz="4" dx="5" Iterations="50" />, and (0,0,0) to be the default.

@mdzik
Copy link
Member Author

mdzik commented Jun 30, 2016

ping ;) shkodm#1

@mdzik
Copy link
Member Author

mdzik commented Jul 7, 2016

Done in #80

@mdzik mdzik closed this as completed Jul 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants