Even more general one ;) #1
Conversation
import from fork
Conflicts: src/Handlers.cpp.Rt
|
Oi :) I have first PR in your repo :p |
|
@mdzik, I will read and review it closer to today's afternoon. Be patient. |
|
OK |
| } | ||
| } | ||
| if (go || n_components == 0 ) { | ||
| notice("... checking <?%s q$name ?>"); |
There was a problem hiding this comment.
notice("Checking <?%s q$name ?> ..."); will look better.
There was a problem hiding this comment.
But in general, I don't think this kind of output in necessary. We should output only if something goes wrong. Maybe in the end of loop body, at line 981 for instance:
if (cond) notice("NaN value occured at <?%s q$name?>...");will be better
|
|
||
| pugi::xml_attribute comp = node.attribute("what"); | ||
| std::vector<std::string> components; | ||
| std::vector<real_t*> buffers; |
There was a problem hiding this comment.
I think, default components should have one element with value "ALL". So, that basic Failcheck Iterations="1000/> will be just checking all quantities.
But, as a matter of fact, we already have class for operating with quantities/names in Handlers, namely name_set in utills.
So it is much easier to do:
nameset s;
pugi::xml_attribute comp = node.attribute("what");
if (comp) {
s.add_from_string(attr.value(),',');
}
else {
s.add_from_string("all",',');
}and in then in the loop, do stuff only for quantities specified,as :
<?R for (q in rows(Quantities)) { ifdef(q$adjoint); ?>
if (s->in("<?%s q$name ?>"))
{
// do stuff
}
<?R }; ifdef(); ?>This looks much nicer, eliminate raw string manipulation and also "go" variable will no longer be needed.
| int ret = 0; | ||
| int cond,fin; | ||
| int ret = 0; | ||
| int cond,fin,go; |
There was a problem hiding this comment.
"go" is no longer used. Remove it.
Some updating of d2q9_adj and example
intall.sh v2 -auto OS detection
+ Addition of (final) 3D thermal particle model from the PhD work of …
Adding asserts on the piece regions in compare
I dont think we need to check vectors, NaNs propagates fast ;)
I've added way to set region and quantities to check