Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added -M option to show generated man page #195

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

mineralsfree
Copy link
Contributor

Ticket: ENT-11824
Changelog: None
Signed-off-by: Mikita Pilinka mikita.pilinka@northern.tech

Copy link
Contributor

@larsewi larsewi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only few nitpicks. Otherwise, great work 🚀

cfbs/args.py Outdated Show resolved Hide resolved
cfbs/args.py Outdated Show resolved Hide resolved
cfbs/args.py Outdated Show resolved Hide resolved
Copy link
Contributor

@vpodzime vpodzime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My two cents on top of Lars'.

cfbs/args.py Outdated Show resolved Hide resolved
cfbs/man_generator.py Outdated Show resolved Hide resolved
cfbs/man_generator.py Outdated Show resolved Hide resolved
cfbs/args.py Outdated Show resolved Hide resolved
cfbs/args.py Outdated Show resolved Hide resolved
Ticket: ENT-11824
Changelog: None
Signed-off-by: Mikita Pilinka <mikita.pilinka@northern.tech>
Copy link
Member

@olehermanse olehermanse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 🚀

Copy link
Contributor

@larsewi larsewi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 🚀

@olehermanse olehermanse merged commit 9f93b06 into cfengine:master Jun 14, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants