Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CFE-3802: 'cfbs update' can now be used to update modules #42

Merged
merged 4 commits into from
Oct 28, 2021

Conversation

vpodzime
Copy link
Contributor

No description provided.

@olehermanse olehermanse changed the title CFE-3802: cfbs update CFE-3802: 'cfbs update' can now be used to update modules Oct 27, 2021
Copy link
Member

@olehermanse olehermanse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general, just some smaller comments.

cfbs/commands.py Outdated Show resolved Hide resolved
cfbs/commands.py Outdated Show resolved Hide resolved
cfbs/commands.py Outdated Show resolved Hide resolved
cfbs/commands.py Outdated Show resolved Hide resolved
cfbs/commands.py Outdated Show resolved Hide resolved
@vpodzime
Copy link
Contributor Author

Looks good in general, just some smaller comments.

All addressed.

Copy link
Member

@olehermanse olehermanse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just fix the conflicts.

That's how nice files should look like.
Do not tell user they are being skipped, but do skip them.

Ticket: CFE-3802
Changelog: None
Just compare the local information with the index and update it
if there's a difference.

Ticket: CFE-3802
Changelog: 'cfbs update' can now be used to update modules
With log level 'error' warnings are not shown.

Ticket: CFE-3802
Changelog: None
@vpodzime vpodzime merged commit a872399 into cfengine:master Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants