-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CFE-3802: 'cfbs update' can now be used to update modules #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olehermanse
changed the title
CFE-3802: cfbs update
CFE-3802: 'cfbs update' can now be used to update modules
Oct 27, 2021
olehermanse
requested changes
Oct 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general, just some smaller comments.
vpodzime
force-pushed
the
master-update
branch
from
October 27, 2021 14:38
fd20495
to
8a22a0b
Compare
All addressed. |
olehermanse
approved these changes
Oct 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just fix the conflicts.
That's how nice files should look like.
Do not tell user they are being skipped, but do skip them. Ticket: CFE-3802 Changelog: None
Just compare the local information with the index and update it if there's a difference. Ticket: CFE-3802 Changelog: 'cfbs update' can now be used to update modules
With log level 'error' warnings are not shown. Ticket: CFE-3802 Changelog: None
vpodzime
force-pushed
the
master-update
branch
from
October 28, 2021 10:51
8a22a0b
to
72182ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.