WIP: CFE-4401: Adjusted use of pthreads for Android/Termux platform #5574
Conversation
Android/Termux doesn't have pthread_cancel so use pthred_kill instead Ticket: CFE-4401 Changelog: title (cherry picked from commit ebd52a29238122c4bcc2f86d2313f9f4a258243c)
| ret = pthread_cancel(thread_data.thread); | ||
| #else | ||
| ret = pthread_kill(thread_data.thread, 0); |
There was a problem hiding this comment.
Is it safe to join a "killed" thread? Will this call the signal handler installed by the agent. If so, is this fine? Also the man pthread_kill(3) says:
If sig is 0, then no signal is sent, but error checking is still performed.
There was a problem hiding this comment.
I should read your blog post, man pages and then try out isreadable() and see how it goes on termux. :)
There was a problem hiding this comment.
Will read https://cfengine.com/blog/2023/check-if-file-is-readable/ and then proceed.
There was a problem hiding this comment.
Looks like there is already a patch in termux-packages we may be able to pull in.
https://github.com/termux/termux-packages/blob/master/packages/cfengine/pthread_cancel.patch
craigcomstock
changed the title
|
There is a fix in termux-packages already for this issue. I will read Lars' blog and the termux-packages patch and see where we want to go with a fix here in core. |
Android/Termux doesn't have pthread_cancel so use pthred_kill instead
Ticket: CFE-4401
Changelog: title