Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

download current view #77

Merged
merged 4 commits into from
Oct 27, 2016
Merged

download current view #77

merged 4 commits into from
Oct 27, 2016

Conversation

curran
Copy link
Collaborator

@curran curran commented Oct 27, 2016

Will close #75

@curran
Copy link
Collaborator Author

curran commented Oct 27, 2016

Now there is a "Download Currently Shown Data" button that downloads CSV data for the currently selected field only. Here's a sample of the CSV output:

State,Year,IndividualToCandLimit_H_Max
"LA",1996,"5000"
"WV",1996,"2000"
"SD",1996,"500"
"NM",1996,""
"NV",1996,"2000"
"VT",1996,"2000"
"AK",1996,"2000"
"HI",1996,"2000"
"KS",1996,"1000"
"SC",1996,"3500"
"OK",1996,"5000"
"MN",1996,"600"
"AL",1996,""
"ID",1996,""
"PA",1996,""
"NE",1996,""

The information about unlimited vs. prohibited is missing, but this gets us a step in the right direction. I have added a follow-on issue about adding the prohibited vs. unlimited information #78

@curran curran changed the title WIP download current view download current view Oct 27, 2016
@curran
Copy link
Collaborator Author

curran commented Oct 27, 2016

Merging for demoability.

@curran curran merged commit 91ba372 into master Oct 27, 2016
@seemantk
Copy link
Collaborator

this is great, @curran. nicely done! we do need to figure out prohibited/unlimited.

@curran
Copy link
Collaborator Author

curran commented Oct 27, 2016

@seemantk Indeed, that is a tricky bit.

What are your thoughts on having a more elaborate pre-processing step, in which the logic for determining prohibited/unlimited is done completely separately from the vis? This would give several benefits:

  • The vis could read a CSV where each column contains the values including special signals for prohibited/unlimited (maybe "0" and "Infinity").
  • The data download button would not need any logic for determining prohibited/unlimited
  • The data download button for the entire limits dataset could simply point to a static CSV file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Download visible data button
2 participants