Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taxonomy suggest #12

Merged
merged 2 commits into from
Jul 31, 2017
Merged

Taxonomy suggest #12

merged 2 commits into from
Jul 31, 2017

Conversation

AdamZarger
Copy link
Contributor

Refactored the CCDB data pipeline such that it can index both complaints and taxonomy. Taxonomy is required for the suggest auto-complete function.

Additions

  • Added logic to index taxonomy

Changes

  • Refactored scripts such that both complaints and taxonomy can be indexed, using the same instance of Elasticsearch and logger

Review

Checklist

  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows the standards laid out in the development playbook
  • Passes all existing automated tests
  • New functions include new tests
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged
  • Visually tested in supported browsers and devices
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

@amymok
Copy link
Contributor

amymok commented Jul 31, 2017

👍

@AdamZarger AdamZarger merged commit 20300e8 into cfpb:master Jul 31, 2017
@AdamZarger AdamZarger deleted the taxonomy_suggest branch October 16, 2019 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants