Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Size #115

Merged
merged 2 commits into from
Jan 22, 2020
Merged

Handle Size #115

merged 2 commits into from
Jan 22, 2020

Conversation

AdamZarger
Copy link
Contributor

Similarly to #106, this change allows us to decouple calls to Elasticsearch for hits and aggregations:

  • If the size parameter is provided as zero (size=0), the request made to Elasticsearch will not return matching complaints, but it will return aggregations with any filters applied.
  • If the no_aggs parameter is provided as True (no_aggs=true) then the request made to Elasticsearch will return matching complaints, but will not return aggregations

Copy link
Contributor

@JeffreyMFarley JeffreyMFarley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 :

@AdamZarger AdamZarger merged commit f136c3e into cfpb:master Jan 22, 2020
@AdamZarger AdamZarger deleted the handle_size branch January 22, 2020 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants