-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unicode searches #57
Unicode searches #57
Conversation
…ious other special characters
Some background on what this PR does: the problem with the search turned out to be mostly about the Elasticsearch backend. In order to get Elastic to do things like turn Unicode characters (e.g. é) into their nearest ASCII equivalent, you need to enable an analyzer filter called This PR also adds a |
Removes existing temporary solution for that; adds a `name` field to the returned data from the SuggestedSearchResult's `to_dict` function; adds output for a suggested result to the search results template.
…s the right thing on ampersands
I'm not sure why Travis's tests are failing. They run fine for me locally, except for one Mystery Meet test (which fails because the fixtures were overridden by my loaded DB dump). That Mystery Meet test does not seem to be failing on Travis, though. |
… unicode_searches
Which was inadvertently added back in a bad merge resolution.
Per discussion in chat, we're going to go ahead with merging this and deploying it to our test server to see if there are any failures there. |
This PR wraps the search term in Django's
smart_text
Unicode converter so that you can do searches using Unicode characters in the search bar.