Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alignment issues in debt sumary for program length #254

Merged
merged 2 commits into from
Aug 4, 2016

Conversation

marteki
Copy link
Member

@marteki marteki commented Aug 4, 2016

Previous bug:

screen shot 2016-08-04 at 3 44 39 pm

Fix:

screen shot 2016-08-04 at 3 47 08 pm

Changes

  • Fix alignment issues in debt summary

Testing

Pull down the branch, gulp, and visually confirm fix.

Review

Checklist

  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows the standards laid out in the front end playbook
  • Passes all existing automated tests
  • New functions include new tests
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged
  • Visually tested in supported browsers and devices
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 17a2def on program-length into 51c12a3 on master.

@mistergone
Copy link
Member

Works for me!

charlie-day-thumbs-up

@higs4281
Copy link
Member

higs4281 commented Aug 4, 2016

👍 confirmed (when 6-month program selected)

@marteki marteki merged commit b909d92 into master Aug 4, 2016
@marteki marteki deleted the program-length branch August 4, 2016 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants