Option to deliver generic national stats #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition to delivering national salary and grad rates tied to program length, this delivers fall-back generic salary and grad-rate values when no school or program is provided or when the bare /api/national-stats/ endpoint is used.
|
Values I get in browser console when running this without a school or program ID:
And verified that it still works for school-program pairs and solo schools. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to delivering national salary and grad rates tied to program
length, this delivers fall-back generic salary and grad-rate values when
the bare
/api/national-stats/endpoint is called without providing a school IDor program ID. This also provides a fallback in case both school ID and program ID are bad.
Additions
Changes
Testing
A call to the
/api/national-stats/bare endpoint, with no school or program ID, should return these generic stats, including the $34,300 overall median salary used in college scorecard comparisons:Calls that provide an extra URL field with a schoolID_programID pair will work as before, delivering salary and grad rate values based on program length.
Review
FYI: @saintsoup52