Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert tabs to spaces #316

Merged
merged 4 commits into from
Jul 23, 2018
Merged

Convert tabs to spaces #316

merged 4 commits into from
Jul 23, 2018

Conversation

anselmbradford
Copy link
Member

@anselmbradford anselmbradford commented Apr 23, 2018 •
edited
Loading

Changes

  • Converts tabs to spaces in templates.
  • Converts single quotes to double in template markup.

@coveralls
Copy link

coveralls commented Apr 23, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 34f0a2a on fix_target_blank into 205f92b on master.

@marteki
Copy link
Member

marteki commented Jul 19, 2018

With the opening of #319, can we close this? @anselmbradford

@anselmbradford
Copy link
Member Author

anselmbradford commented Jul 19, 2018 •
edited
Loading

Oh hey! I did think I'd fixed this! Hmmm maybe I'll merge 319 and see how bad the conflict is here and then update this to convert the tabs to spaces.

@anselmbradford anselmbradford changed the title Add noopener noreferrer to link targets Convert tabs to spaces Jul 19, 2018
@anselmbradford
Copy link
Member Author

@marteki ready to review again

@anselmbradford anselmbradford merged commit 3a4d6af into master Jul 23, 2018
@anselmbradford anselmbradford deleted the fix_target_blank branch July 23, 2018 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marteki marteki marteki approved these changes

@mistergone mistergone Awaiting requested review from mistergone

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anselmbradford @coveralls @marteki